[Differential] [Request, 154 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5
marten (Jonathan Marten)
noreply at phabricator.kde.org
Sun Sep 25 11:55:45 UTC 2016
marten created this revision.
marten added a reviewer: Plasma.
marten set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
marten added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The "Advanced" and "Keyboard Navigation" tabs of the mouse control panel (kcmshell5 mouse) contain a number of spin boxes, all of which were originally at their natural widths (see "before" screen shots):
F341313: mouse-kcmshell-before-2.png <https://phabricator.kde.org/F341313>
F341312: mouse-kcmshell-before-1.png <https://phabricator.kde.org/F341312>
This change improves the appearance by aligning them all to have the same width:
F341315: mouse-kcmshell-after-2.png <https://phabricator.kde.org/F341315>
F341314: mouse-kcmshell-after-1.png <https://phabricator.kde.org/F341314>
In addition to this, the spin boxes are ported from the deprecated KNumInput to QSpinBox/QDoubleSpinBox as appropriate, and some cruft (including unneeded include files) is removed.
TEST PLAN
Built mouse KCM with these changes, checked appearance and operation.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2853
AFFECTED FILES
kcms/input/kmousedlg.ui
kcms/input/mouse.cpp
kcms/input/mouse.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160925/c56eae43/attachment.html>
More information about the Plasma-devel
mailing list