<table><tr><td style="">marten created this revision.<br />marten added a reviewer: Plasma.<br />marten set the repository for this revision to rPLASMADESKTOP Plasma Desktop.<br />marten added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2853" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The "Advanced" and "Keyboard Navigation" tabs of the mouse control panel (kcmshell5 mouse) contain a number of spin boxes, all of which were originally at their natural widths (see "before" screen shots):</p>
<p><a href="https://phabricator.kde.org/F341313" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F341313: mouse-kcmshell-before-2.png</a></p>
<p><a href="https://phabricator.kde.org/F341312" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F341312: mouse-kcmshell-before-1.png</a></p>
<p>This change improves the appearance by aligning them all to have the same width:</p>
<p><a href="https://phabricator.kde.org/F341315" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F341315: mouse-kcmshell-after-2.png</a></p>
<p><a href="https://phabricator.kde.org/F341314" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F341314: mouse-kcmshell-after-1.png</a></p>
<p>In addition to this, the spin boxes are ported from the deprecated KNumInput to QSpinBox/QDoubleSpinBox as appropriate, and some cruft (including unneeded include files) is removed.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Built mouse KCM with these changes, checked appearance and operation.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2853" rel="noreferrer">https://phabricator.kde.org/D2853</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/input/kmousedlg.ui<br />
kcms/input/mouse.cpp<br />
kcms/input/mouse.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>marten, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>