Review Request 129005: Mark kirigami as runtime component

Rex Dieter rdieter at gmail.com
Fri Sep 23 21:42:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129005/
-----------------------------------------------------------

(Updated Sept. 23, 2016, 9:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit dbefdc3e0a4fca782e0d22b9f2bac4763a1ba883 by Rex Dieter to branch Plasma/5.8.


Repository: discover


Description
-------

Kirigami is not really a required build-time component, so mark it as runtime instead.


Diffs
-----

  CMakeLists.txt 2756fb1 

Diff: https://git.reviewboard.kde.org/r/129005/diff/


Testing
-------

build succeeds, cmake output now includes:

-- The following RUNTIME packages have been found:

 * KF5Kirigami (required version >= 1.0) , KDE’s lightweight user interface framework for mobile and convergent applications , <https://techbase.kde.org/Kirigami>
   Required by discover qml components


Thanks,

Rex Dieter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160923/4ca9f2f6/attachment-0001.html>


More information about the Plasma-devel mailing list