Review Request 129005: Mark kirigami as runtime component

Aleix Pol Gonzalez aleixpol at kde.org
Fri Sep 23 18:43:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129005/#review99489
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On set. 23, 2016, 8:19 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129005/
> -----------------------------------------------------------
> 
> (Updated set. 23, 2016, 8:19 p.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: discover
> 
> 
> Description
> -------
> 
> Kirigami is not really a required build-time component, so mark it as runtime instead.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2756fb1 
> 
> Diff: https://git.reviewboard.kde.org/r/129005/diff/
> 
> 
> Testing
> -------
> 
> build succeeds, cmake output now includes:
> 
> -- The following RUNTIME packages have been found:
> 
>  * KF5Kirigami (required version >= 1.0) , KDE’s lightweight user interface framework for mobile and convergent applications , <https://techbase.kde.org/Kirigami>
>    Required by discover qml components
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160923/8e3a71b7/attachment.html>


More information about the Plasma-devel mailing list