[Differential] [Requested Changes To] D2845: some sni implementations theme not under /icons

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Can you start to fill in the "testing done" section properly.

INLINE COMMENTS

> systemtray.cpp:180
>                  auto tokens = path.splitRef('/', QString::SkipEmptyParts);
> -                if (tokens.length() >= 3 && tokens.takeLast() == QLatin1String("icons")) {
> +                if (tokens.length() >= 3) {
>                      const QString appName = tokens.takeLast().toString();

This is totally 100% wrong!

tokens.takeLast() will modify tokens

By removing it, you've changed the behaviour or the next line

appName = tokens.takeLast().

Meaning this patch would break every single correct application in the system tray

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2845

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160923/e12e5bab/attachment.html>