<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a reviewer: davidedmundson.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2845" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Can you start to fill in the "testing done" section properly.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2845#inline-11098" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemtray.cpp:180</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">auto</span> <span class="n">tokens</span> <span style="color: #aa2211">=</span> <span class="n">path</span><span class="p">.</span><span class="n">splitRef</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">tokens</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">3<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="n"><span class="bright">tokens</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">takeLast</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"icons"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">tokens</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">3</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">appName</span> <span style="color: #aa2211">=</span> <span class="n">tokens</span><span class="p">.</span><span class="n">takeLast</span><span class="p">().</span><span class="n">toString</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is totally 100% wrong!</p>

<p style="padding: 0; margin: 8px;">tokens.takeLast() will modify tokens</p>

<p style="padding: 0; margin: 8px;">By removing it, you've changed the behaviour or the next line</p>

<p style="padding: 0; margin: 8px;">appName = tokens.takeLast().</p>

<p style="padding: 0; margin: 8px;">Meaning this patch would break every single correct application in the system tray</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2845" rel="noreferrer">https://phabricator.kde.org/D2845</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>