Discover requires Qt 5.7?

[Matthias Klumpp]

2016-09-22 14:36 GMT+02:00 Matthias Klumpp <matthias at tenstral.net>:
> 2016-09-22 13:15 GMT+02:00 Jonathan Riddell <jr at jriddell.org>:
>> On Thu, Sep 22, 2016 at 01:02:45PM +0200, Aleix Pol wrote:
>>> On Thu, Sep 22, 2016 at 10:20 AM, Daniel Vrátil <dvratil at kde.org> wrote:
>>> > Hi,
>>> >
>>> > Discover 5.7.95 requires Qt 5.7 due to usage of qAsConst() [0], although
>>> > CMakeLists.txt claims Qt 5.2 is required (which seems to be too low anyway).
>>> >
>>> > Can you please either replace qAsConst() with const_cast or bump the Qt
>>> > dependency?
>>> >
>>> > Thanks,
>>> > Dan
>>> >
>>> > [0] https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-5.7.95/
>>> > fedora-24-x86_64/00455948-plasma-discover/build.log.gz
>>>
>>> This and other problems have been fixed lately, when I was pointed
>>> this could be a problem. The next beta will work with Qt 5.6.
>>
>> There's no more betas, only a final release next week, so verification before then would be good.
>
> I requested that change, tested it and it works ~okay - there are some
> UI / font rendering issues, but all of those problems are apparently
> caused by Qt itself, so nothing we can solve. Also, they don't make
> using Discover impossible or harder, it just doesn't look as nice.
>
> So, for me it's working with Debian's version of Qt 5.6.

One addition: If Kirigami is missing on the system, Discover will
build but simply crash on startup - so, we should make the application
handle this case better (= not crash) or simply depend on Kirigami at
build-time, so people don't forget to make it available.
Especially for distributors this is kind of important, so they get the
dependencies set correctly.

Cheers,
    Matthias

-- 
Debian Developer | Freedesktop-Developer
I welcome VSRE emails. See http://vsre.info/