[Differential] [Accepted] D2785: Fix panel spacer
    mart (Marco Martin) 
    noreply at phabricator.kde.org
       
    Thu Sep 15 08:58:49 UTC 2016
    
    
  
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> main.qml:36
>  
> -    Layout.minimumWidth: horizontal ? plasmoid.configuration.length : 1
> -    Layout.maximumWidth: (plasmoid.configuration.expanding || !horizontal) ? Infinity :  plasmoid.configuration.length
> -
> -    Layout.minimumHeight: horizontal ? 1 : plasmoid.configuration.length
> -    Layout.maximumHeight: (plasmoid.configuration.expanding || horizontal) ? Infinity :  plasmoid.configuration.length
> +    Layout.preferredWidth: horizontal ? plasmoid.configuration.length : 0
> +    Layout.preferredHeight: horizontal ? 0 : plasmoid.configuration.length
some time ago on old qt releases i noticed that the layouts  ignored items with one of the sizes as 0 (even height for an horizontal one)  does it work now?
REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace
BRANCH
  master
REVISION DETAIL
  https://phabricator.kde.org/D2785
EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160915/f7dbce64/attachment.html>
    
    
More information about the Plasma-devel
mailing list