Review Request 128899: xcursor discovery: modernize

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128899/#review99165
-----------------------------------------------------------



+1
We discussed a similar patch for kde-gtk-config.

There's no point in supporting xcursor older than 1.1, as it's over 10 years old.
The rest is just an adoption of newer APIs.

- Aleix Pol Gonzalez


On Sept. 14, 2016, 12:11 p.m., Jason A. Donenfeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128899/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 12:11 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> First we remove the fallback code for a version of Xcursor that
> corresponds with an X server KDE doesn't even support any more.
> 
> Then we reverse the order of tilde expansion and deduplication, which
> before was essentially incorrect.
> 
> Next we do deduplication properly, using Qt's removeDuplicates function.
> 
> Finally we replace the ugly regex with the helper function in
> kcoreextras via std::transform.
> 
> This work here reflects the recent review and discussion that went into
> the nearly identical code in kde-gtk-kcm.
> 
> 
> Diffs
> -----
> 
>   kcms/cursortheme/xcursor/thememodel.cpp e0cb420b7787261d9b5a54b9c0d448d8dd65a988 
> 
> Diff: https://git.reviewboard.kde.org/r/128899/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason A. Donenfeld
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160914/35400423/attachment.html>