<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128899/">https://git.reviewboard.kde.org/r/128899/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1
We discussed a similar patch for kde-gtk-config.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's no point in supporting xcursor older than 1.1, as it's over 10 years old.
The rest is just an adoption of newer APIs.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 14th, 2016, 12:11 p.m. CEST, Jason A. Donenfeld wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson and Marco Martin.</div>
<div>By Jason A. Donenfeld.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2016, 12:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First we remove the fallback code for a version of Xcursor that
corresponds with an X server KDE doesn't even support any more.
Then we reverse the order of tilde expansion and deduplication, which
before was essentially incorrect.
Next we do deduplication properly, using Qt's removeDuplicates function.
Finally we replace the ugly regex with the helper function in
kcoreextras via std::transform.
This work here reflects the recent review and discussion that went into
the nearly identical code in kde-gtk-kcm.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/cursortheme/xcursor/thememodel.cpp <span style="color: grey">(e0cb420b7787261d9b5a54b9c0d448d8dd65a988)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128899/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>