[Differential] [Requested Changes To] D2766: More config descriptions

hein (Eike Hein) noreply at phabricator.kde.org
Wed Sep 14 07:13:41 UTC 2016


hein requested changes to this revision.
hein added a reviewer: hein.
hein added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.xml:10
>      <entry name="showLocalTimezone" type="Bool">
> +      <label>Whether the timezone should be displayed when the clock is showing the local timezone</label>
>        <default>false</default>

I know this is increeeedibly nitpicky, but ... I ended the labels in the other applets with periods, could we make this consistent? :)

> main.xml:26
>      <entry name="fontFamily" type="string">
> +      <label>Font family. Should be a valid font string</label>
>        <default></default>

What's a valid font string?

> main.xml:30
>      <entry name="boldText" type="Bool">
> +      <label>Sets the fault to bold</label>
>        <default>false</default>

s/fault/font

> main.xml:44
>      </entry>
>      <entry name="lastSelectedTimezone" type="String">
> +      <label>The timezone to show when Plasma loads.</label>

Could be nicer, something like "When multiple time zones are configured, this is the one shown on widget restore."

> main.xml:49
>      <entry name="wheelChangesTimezone" type="Bool">
> +      <label>Whether the mouse wheel changes the time zone displayed using the selectedTimeZones options above.</label>
>        <default>false</default>

*switches between the time zones configured in selectedTimeZones.

> main.xml:57
>      <entry name="showWeekNumbers" type="Bool">
> +      <label>If the calendar should show week numbers</label>
>        <default>false</default>

*Whether

> main.xml:10
>      <entry name="sources" type="StringList">
> +      <label>A comma separate list of sources to display in this system monitor. IDs can be found via the plasmaengineexplorer application.</label>
>      </entry>

*comma-separated

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2766

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160914/0acfb13d/attachment.html>


More information about the Plasma-devel mailing list