<table><tr><td style="">hein requested changes to this revision.<br />hein added a reviewer: hein.<br />hein added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2766" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10852" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"showLocalTimezone"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"Bool"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>Whether the timezone should be displayed when the clock is showing the local timezone<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><default></span>false<span style="color: #00702a"></default></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know this is increeeedibly nitpicky, but ... I ended the labels in the other applets with periods, could we make this consistent? :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10853" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:26</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"fontFamily"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"string"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>Font family. Should be a valid font string<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><default></default></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What's a valid font string?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10854" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"boldText"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"Bool"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>Sets the fault to bold<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><default></span>false<span style="color: #00702a"></default></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/fault/font</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10855" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></entry></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"lastSelectedTimezone"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"String"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>The timezone to show when Plasma loads.<span style="color: #00702a"></label></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could be nicer, something like "When multiple time zones are configured, this is the one shown on widget restore."</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10856" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"wheelChangesTimezone"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"Bool"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>Whether the mouse wheel changes the time zone displayed using the selectedTimeZones options above.<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><default></span>false<span style="color: #00702a"></default></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">*switches between the time zones configured in selectedTimeZones.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10857" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"showWeekNumbers"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"Bool"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>If the calendar should show week numbers<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><default></span>false<span style="color: #00702a"></default></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">*Whether</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2766#inline-10858" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"sources"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"StringList"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>A comma separate list of sources to display in this system monitor. IDs can be found via the plasmaengineexplorer application.<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></entry></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">*comma-separated</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2766" rel="noreferrer">https://phabricator.kde.org/D2766</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, hein<br /><strong>Cc: </strong>hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>