Review Request 128552: Italicise the name of symlink in folder view plasmoid

Chinmoy Ranjan Pradhan chinmoyrp65 at gmail.com
Sat Sep 10 05:47:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/
-----------------------------------------------------------

(Updated Sept. 10, 2016, 5:47 a.m.)


Review request for Plasma and Eike Hein.


Changes
-------

Splited the RR into two parts. 
This one for italicising of symlink name and RR 128683 for the overlay part.


Summary (updated)
-----------------

Italicise the name of symlink in folder view plasmoid


Repository: plasma-desktop


Description (updated)
-------

Same as summary.


Diffs (updated)
-----

  containments/desktop/package/contents/ui/FolderItemDelegate.qml b313d0f 
  containments/desktop/plugins/folder/foldermodel.h 0e31b1e 
  containments/desktop/plugins/folder/foldermodel.cpp 6abfb6b 

Diff: https://git.reviewboard.kde.org/r/128552/diff/


Testing
-------

build


File Attachments (updated)
----------------

symlinks and other files/folders look similar
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
after patch , everything looks fine
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
before patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/09/10/860d5b48-b88f-4994-bc70-ae8b6e4c91f7__beforepatch.png
after patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/09/10/75649c76-e67e-41fb-8a37-3a73d2cae9b7__afterpatch.png


Thanks,

Chinmoy Ranjan Pradhan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160910/d9efd270/attachment.html>


More information about the Plasma-devel mailing list