Review Request 128849: [AppletQuickItem] Reduce string comparisons

Kai Uwe Broulik kde at privat.broulik.de
Tue Sep 6 14:19:24 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128849/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

It's not like applet() can change, can it?

On my maching nativeInterface is called 90 times (System Tray and Notifications use it), doing a string comparison every time.


Diffs
-----

  src/scriptengines/qml/plasmoid/appletinterface.h a215ddd 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 

Diff: https://git.reviewboard.kde.org/r/128849/diff/


Testing
-------

System Tray and Notifications still work


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/427c5c44/attachment-0001.html>


More information about the Plasma-devel mailing list