[Differential] [Updated] D2672: Remove pointless code

mart (Marco Martin) noreply at phabricator.kde.org
Tue Sep 6 09:14:29 UTC 2016


mart added a comment.


  removing it makes sense to me
  as that code is weird, here's my research on its history:
  
  looking at why it was inserted:
  commit https://phabricator.kde.org/rPLASMADESKTOP0cf01e3d2a5b8a2e23dad50cfdefffdc093c6bee
  "This patch fixes this warning and also some rendering issues in the panel's settings dialog, where the buttons would have different sizes when laid out vertically."
  
  also in part
  commit https://phabricator.kde.org/rPLASMADESKTOPfa8270162d99a9807e2c93c1c52c821a9dd22ad4
  "don't auto resize when the panel controller is open"
  
  for https://phabricator.kde.org/rPLASMADESKTOPfa8270162d99a9807e2c93c1c52c821a9dd22ad4, this blind emitting of signals doesn't apply anymore, so the patch shoud good to go in

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/2c1f524b/attachment-0001.html>


More information about the Plasma-devel mailing list