[Differential] [Request, 14 lines] D2672: Remove pointless code

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Tue Sep 6 08:40:04 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It doesn't make sense to emit a signal in someone elses layout object
  
  1. only the containment.Layout.preferedSize is ever used
  2. and the only user (panel.qml) is constantly bound anwyay.
  
  I assume it was an attempted workaround for the bug in the panelview
  length cleanup that I did ages ago.

TEST PLAN
  Resized all the things in plasma configure mode.
  No changes.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2672

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/7a19dd91/attachment.html>


More information about the Plasma-devel mailing list