[Differential] [Accepted] D2645: make sure the vertical systary size hints are fixed

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  You don't need to guess, the code is open source...
  
  Here is the reason.
  
  panel/main.qml
  
  the container has:
  
    Layout.preferredHeight: (!currentLayout.isLayoutHorizontal ? (applet && applet.Layout.preferredHeight > 0 ? applet.Layout.preferredHeight : root.width) : root.height)
  
  This means that even though the system tray has no preferredHeight, the container, which is what the layout sees does.  The layout will fit an item to fit it's preferred height before it will let another item fill height.
  
  basically making all trays square if they don't specify anything else.
  
  Put that in the commit message and use you can ship this; though setting the preferredHeight is probably more correct.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/systrayvertical

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160904/5a0462aa/attachment.html>