Review Request 129294: Removed unwanted clear button while having inline clear option.

[Aniketh Girish]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129294/#review100436
-----------------------------------------------------------


Ship it!




Ship It!

- Aniketh Girish


On Oct. 31, 2016, 1:13 p.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129294/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 1:13 p.m.)
> 
> 
> Review request for Plasma, David Faure and Eike Hein.
> 
> 
> Bugs: 369377
>     https://bugs.kde.org/show_bug.cgi?id=369377
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> There was a unwanted clear button as well as a inline clear. The clear button was old enough, so removed that button and the inline clear does the work.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kurlrequesterdialog.h ea2533310fdb69bf8f4ac6bae826ea45439fdeb6 
>   src/widgets/kurlrequesterdialog.cpp 4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204 
> 
> Diff: https://git.reviewboard.kde.org/r/129294/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before removing the clear button.
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b28e7448-0b6a-4a5b-a410-ff8523596784__Before_Changes.png
> After changing the code for clear button.
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b45f8107-5c4f-4697-b1ae-7c0431259fcb__After_Changes.png
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/4855a135/attachment-0001.html>