Review Request 129294: Removed unwanted clear button while having inline clear option.
Aniketh Girish
anikethgireesh at gmail.com
Mon Oct 31 13:13:08 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129294/
-----------------------------------------------------------
(Updated Oct. 31, 2016, 1:13 p.m.)
Review request for Plasma, David Faure and Eike Hein.
Bugs: 369377
https://bugs.kde.org/show_bug.cgi?id=369377
Repository: kio
Description
-------
There was a unwanted clear button as well as a inline clear. The clear button was old enough, so removed that button and the inline clear does the work.
Diffs (updated)
-----
src/widgets/kurlrequesterdialog.h ea2533310fdb69bf8f4ac6bae826ea45439fdeb6
src/widgets/kurlrequesterdialog.cpp 4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204
Diff: https://git.reviewboard.kde.org/r/129294/diff/
Testing
-------
File Attachments
----------------
Before removing the clear button.
https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b28e7448-0b6a-4a5b-a410-ff8523596784__Before_Changes.png
After changing the code for clear button.
https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b45f8107-5c4f-4697-b1ae-7c0431259fcb__After_Changes.png
Thanks,
Aniketh Girish
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/118a661f/attachment.html>
More information about the Plasma-devel
mailing list