[Differential] [Commented On] D3166: make sure containment actions config is up to date

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3166#58841, @davidedmundson wrote:
  
  > Also this script is making an optimistic assumption that in the script where you might be modding containment configs, you'd create a containment instance. That's not always true (like from the evaluate script DBus calls).
  
  
  yeah, if no containment wrapper instances exist, this may not get executed.
  I think it should probably be attempted when tearing down the whole scripting engine stuff instead.
  
  in order to make adding actions (or changing existing ones) working, a loop of Containment::setContainmentActions should be executed looping trought the config that just has been written
  
  > Maybe do this for 5.8, but you really need to expose a new method (or even Actions object) to do this properly - or to delay the loading.
  
  I would really like to avoid creating any new api  with this qtscript stuff, given the state of qtscript, but I think is feasible to make the current manual config poking fully work.
  existing scripts in 5.8 has to work, so yeah.
  i don't see possible delaying the loading, as the desktop containment has to already exist by the time the script is executed (see the long story of fixes of scripting during the early 5.7)
  
  > BTW: The script in the bug report has a bug, it's only going to configure the actions on containment 0; even though you'll be reconfiguring the "correct" one.
  
  no, that group is not the containment id, it is the containment type, so [ActionPlugins][0] means plugins for desktop containments, [ActionPlugins][1] for panel containments (enum ContainmentType in plasma.h) so that script correctly changes actions for "desktop" containments

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161026/4a304e29/attachment.html>