[Differential] [Requested Changes To] D3166: make sure containment actions config is up to date

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Edit, I think I understand.
  
  So the script is modifying the actions not through some actions part of the API, but through just manually prodding the config.
  Manually prodding the config naturally has no effect at runtime changes.
  
  This isn't a very thorough solution.
  
  You're covering containment actions being reconfigured, but not covering them being added or removed - an equally plausible thing to script.
  
  Also this script is making an optimistic assumption that in the script where you might be modding containment configs, you'd create a containment instance. That's not always true (like from the evaluate script DBus calls).
  
  Maybe do this for 5.8, but you really need to expose a new method (or even Actions object) to do this properly - or to delay the loading.
  
  BTW: The script in the bug report has a bug, it's only going to configure the actions on containment 0; even though you'll be reconfiguring the "correct" one.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161026/03e3c75a/attachment-0001.html>