[Differential] [Request, 1 line] D3165: Remove line that does nothing

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Wed Oct 26 11:42:10 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  AppletInterface is designed to expose Applet methods to QML space.
  
  Emitting a signal on appletinterface from QML doesn't acheieve anything
  as all we'll do is notify the QML code which we're already in.
  
  We intention was probably to re-evaluate anything connected to
  Applet::contextualActionsAboutToShow, but that's not happening.

TEST PLAN
  Opened toolbox, it looked the same

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3165

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161026/613f560d/attachment.html>


More information about the Plasma-devel mailing list