Review Request 129263: Don't show "Alternatives" menu by default

David Edmundson david at davidedmundson.co.uk
Wed Oct 26 11:37:21 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129263/
-----------------------------------------------------------

(Updated Oct. 26, 2016, 1:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c2465889991a2ebc88195dd008e49afdff7023a5 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

And only enable it in the contextMenuAboutToShow connection.

We currently enable/disable the menu in this slot, but we default to it on. This meant other users of actions() that can't correctly emit contextMenuAboutToShow gain an extra entry which might not be relevant.


Diffs
-----

  src/plasma/private/applet_p.cpp bfb6d2502a2fc804497e571e7000e20a40a20d5c 

Diff: https://git.reviewboard.kde.org/r/129263/diff/


Testing
-------

Appears on kickoff
Doesn't appear on the system tray

(as before)

No longer appears in the toolbox (new fix)


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161026/73fd3d2d/attachment.html>


More information about the Plasma-devel mailing list