Review Request 129234: Guard against Q_GLOBAL_STATIC being destroyed at app shutdown

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129234/
-----------------------------------------------------------

(Updated Oct. 21, 2016, 11:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 579c87a6b25152cd5c36aed10eb5509354316f62 by David Edmundson to branch master.


Repository: kpackage


Description
-------

My last commit to work round an obscure crash introduced a more common crash. Oops. At least it's not released.

Q_GLOBAL_STATIC objects get deleted at app shutdown, however it seems so
do some other KPackage objects.

There's no point updating potentially finishing kjobs at shutdown, so we
can simply put a guard around the global object.


Diffs
-----

  src/kpackage/package.cpp a47f8c8d93335470c0dedb0cda80b514c3611894 

Diff: https://git.reviewboard.kde.org/r/129234/diff/


Testing
-------

kquitapp5 plasmashell, no crashes.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161021/138594f9/attachment.html>