Review Request 129234: Guard against Q_GLOBAL_STATIC being destroyed at app shutdown

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129234/#review100192
-----------------------------------------------------------


Fix it, then Ship it!





src/kpackage/package.cpp (line 67)
<https://git.reviewboard.kde.org/r/129234/#comment67293>

    kdelibs style if () {
    }
    also for one liners


- Marco Martin


On Oct. 21, 2016, 12:03 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129234/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 12:03 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> My last commit to work round an obscure crash introduced a more common crash. Oops. At least it's not released.
> 
> Q_GLOBAL_STATIC objects get deleted at app shutdown, however it seems so
> do some other KPackage objects.
> 
> There's no point updating potentially finishing kjobs at shutdown, so we
> can simply put a guard around the global object.
> 
> 
> Diffs
> -----
> 
>   src/kpackage/package.cpp a47f8c8d93335470c0dedb0cda80b514c3611894 
> 
> Diff: https://git.reviewboard.kde.org/r/129234/diff/
> 
> 
> Testing
> -------
> 
> kquitapp5 plasmashell, no crashes.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161021/c73c49b7/attachment.html>