[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue Oct 18 05:22:07 UTC 2016


graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in kdeplatformtheme.cpp:59
> That's what Qt does and I don't think Qt is equipped to re-create a platform menu at runtime; at least that's what I was told when I raised the very same concern in the upstream Qt codereview that added this.
> 
> We could perhaps do it for newly created menus but when the service becomes unavailable at runtime there's no way for us to re-create existing menus.

hmm then we need to make sure that changing the option cannot be done at runtime - it has to require a session restart.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161018/a41585a7/attachment.html>


More information about the Plasma-devel mailing list