[Differential] [Accepted] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.




INLINE COMMENTS

> Background.qml:56
> +            name: "colorBackground"
> +            when: sceneBackgroundType == "color"
> +            PropertyChanges {

it might be better to have color as the default state (i.e no when clause)

that way a corrupt config will still render a black background.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2983

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bgupta, davidedmundson
Cc: markuss, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/edbbff4e/attachment-0001.html>