[Differential] [Changed Subscribers] D2787: Add support for resize only borders on Wayland

[sebas (Sebastian Kügler)]

sebas added inline comments.

INLINE COMMENTS

> decoration_input_test.cpp:514
> +    QTest::newRow("wlShell - bottom") << Test::ShellSurfaceType::WlShell << Qt::BottomEdge << Qt::SizeVerCursor;
> +    QTest::newRow("xdgShellV5 - bottom") << Test::ShellSurfaceType::XdgShellV5 << Qt::BottomEdge << Qt::SizeVerCursor;
> +}

Top edge? Also, what about the corners?

> decoration_input_test.cpp:522
> +    // first adjust config
> +    kwinApp()->config()->group("org.kde.kdecoration2").writeEntry("BorderSize", QStringLiteral("None"));
> +    kwinApp()->config()->sync();

I don't see any call to QStandardPaths::setTestModeEnabled(...), are you overwriting the user's config here?

http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled

> decoration_input_test.cpp:551
> +        break;
> +    default:
> +        break;

TopEdge missing?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2787

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161004/58538c57/attachment.html>