<table><tr><td style="">sebas added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2787" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2787#inline-11364" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decoration_input_test.cpp:514</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"wlShell - bottom"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">ShellSurfaceType</span><span style="color: #aa2211">::</span><span class="n">WlShell</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">BottomEdge</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SizeVerCursor</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">newRow</span><span class="p">(</span><span style="color: #766510">"xdgShellV5 - bottom"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">ShellSurfaceType</span><span style="color: #aa2211">::</span><span class="n">XdgShellV5</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">BottomEdge</span> <span style="color: #aa2211"><<</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SizeVerCursor</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Top edge? Also, what about the corners?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2787#inline-11365" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decoration_input_test.cpp:522</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #74777d">// first adjust config</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">config</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">group</span><span class="p">(</span><span style="color: #766510">"org.kde.kdecoration2"</span><span class="p">).</span><span class="n">writeEntry</span><span class="p">(</span><span style="color: #766510">"BorderSize"</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"None"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">config</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">sync</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't see any call to QStandardPaths::setTestModeEnabled(...), are you overwriting the user's config here?</p>

<p style="padding: 0; margin: 8px;"><a href="http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2787#inline-11366" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decoration_input_test.cpp:551</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">TopEdge missing?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2787" rel="noreferrer">https://phabricator.kde.org/D2787</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: </strong>sebas, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts<br /></div>