[Differential] [Updated, 170 lines] D2853: Mouse KCM: Align spin boxes, port to Qt5

marten (Jonathan Marten) noreply at phabricator.kde.org
Mon Oct 3 11:32:48 UTC 2016


marten updated this revision to Diff 7051.
marten added a comment.


  Using a form layout wrapped in an outer layout with stretch added to the right.  Gives the intended effect, with all spin boxes the same size and lining up on both tabs.  The boxes for the "Keyboard Navigation" tab are wider than they should be, because the check box makes the form layout wider - probably not worth the complexity of fixing, the appearance is at least better than before.
  
  The indentation here is awful, especially the "Keyboard Navigation" block enclosed in spurious braces and then indented outwards...  I've kept that which exists at the moment, and will fix in a separate commit so as not to mix code and whitespace changes.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2853?vs=7049&id=7051

REVISION DETAIL
  https://phabricator.kde.org/D2853

AFFECTED FILES
  kcms/input/kmousedlg.ui
  kcms/input/mouse.cpp
  kcms/input/mouse.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, davidedmundson, #plasma
Cc: andreaska, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161003/13009ca8/attachment.html>


More information about the Plasma-devel mailing list