[Differential] [Commented On] D3502: Provide scale offset to WindowVertex calculation

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > What about using a textureMatrix and do the mapping in the shader?
  
  In an earlier version I did have
  
    Scene::renderWindow
    if (node == ContentLeaf) {    setScale(topLevel->scale);  }
  
  which I think is effectively what you're suggesting?
  
  It does sort of work; but that just opens a different pandoras box. You now have a WindowVertex with a textureX and textureY which are just wrong.
  Any effect that (implicitly) relies on them, is now broken.
  
  In either case it's going to be a case of manually trying every effect and seeing what's broken.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3502

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161125/483e9e3f/attachment.html>