[Differential] [Commented On] D3480: [effects] Add a colorpicker effect

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in colorpicker.cpp:51
> So this won't work in case of QPainter? Maybe the color picker should communicate that to the user when it's not possible to pick a color?

The supported means KWin won't load the effect at all. How to communicate that to the user is then up to the UI which tries to invoke the Colorpicker. You will get a DBus error.

Also in future I don't see a reason to not also support QPainter

> broulik wrote in colorpicker.h:37
> David complained about using different interfaces in another review (I'm fine with that though)

No, he complained about different services. Different interface was fine.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3480

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161124/1089b98f/attachment.html>