[Differential] [Commented On] D3480: [effects] Add a colorpicker effect

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> colorpicker.cpp:51
> +{
> +    return effects->isOpenGLCompositing();
> +}

So this won't work in case of QPainter? Maybe the color picker should communicate that to the user when it's not possible to pick a color?

> colorpicker.h:37
> +    Q_OBJECT
> +    Q_CLASSINFO("D-Bus Interface", "org.kde.kwin.ColorPicker")
> +public:

David complained about using different interfaces in another review (I'm fine with that though)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3480

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161124/b5791805/attachment.html>