Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/#review100873
-----------------------------------------------------------



Thanks for patch, I've submitted it and will be available when plasma-phone-settings get rebuilt next.

- Bhushan Shah


On Nov. 16, 2016, 4:38 p.m., Konrad Feldmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129412/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, 4:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-phone-settings
> 
> 
> Description
> -------
> 
> Fix wifi-setup fails when psk contains spaces
> 
> Given a wifi password such as `this is my psk`, prior to this
> change `wifi-setup` sent the command:
> 
>     nmcli c modify MYSSID wifi-sec.psk this is my psk
> 
> which would fail with a complaint about `this` not being a valid psk.
> 
> 
> Diffs
> -----
> 
>   usr/bin/wifi-setup a2dac78 
> 
> Diff: https://git.reviewboard.kde.org/r/129412/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konrad Feldmeier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161116/88d1477e/attachment.html>