Review Request 129412: Fix an issue with the `wifi-setup` script for plasma mobile, where certain psk's are not properly added with `nmcli`

Konrad Feldmeier konrad at brainbot.com
Wed Nov 16 11:08:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129412/
-----------------------------------------------------------

(Updated Nov. 16, 2016, 6:08 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c844d95baa920f9558c3e41d7b3bf20e7ba3241b by Bhushan Shah on behalf of Konrad Feldmeier to branch master.


Repository: plasma-phone-settings


Description
-------

Fix wifi-setup fails when psk contains spaces

Given a wifi password such as `this is my psk`, prior to this
change `wifi-setup` sent the command:

    nmcli c modify MYSSID wifi-sec.psk this is my psk

which would fail with a complaint about `this` not being a valid psk.


Diffs
-----

  usr/bin/wifi-setup a2dac78 

Diff: https://git.reviewboard.kde.org/r/129412/diff/


Testing
-------


Thanks,

Konrad Feldmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161116/3fd0d274/attachment-0001.html>


More information about the Plasma-devel mailing list