[Differential] [Changed Subscribers] D3365: Implement interactive window selection for Wayland platforms

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> input.cpp:488
> +            if (event->buttons() == Qt::NoButton) {
> +                if (event->button() == Qt::RightButton) {
> +                    cancel();

Can this happen? You check for buttons being NoButton and then for button being RightButton?

> input.cpp:1409
>          installInputEventFilter(new LockScreenFilter);
> +        m_windowSelector = new WindowSelectorFilter;
> +        installInputEventFilter(m_windowSelector);

Where is that being cleaned up?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161115/dce1b88a/attachment-0001.html>