Review Request 128907: Remove Konqueror kcm docbooks from plasma-desktop repo

[Burkhard Lück]

> On Sept. 14, 2016, 2:55 nachm., Aleix Pol Gonzalez wrote:
> > will you do the move from kde-runtime -> kdebase-apps?
> 
> Luigi Toscano wrote:
>     First we may want to split kde-baseapps (see the email on kde-core-devel), but apart from that, yes.
> 
> Burkhard Lück wrote:
>     ALeix:
>     > will you do the move from kde-runtime -> kdebase-apps?
>     
>     I'll do that when kde-baseapps are splitted
>     
>     Luigi:
>     > First we may want to split kde-baseapps (see the email on kde-core-devel), but apart from that, yes.
>     
>     we should remove the docbooks immediately, it is completely wrong to ship them with Plasma and the konqueror kcm docbooks will be moved from kde-runtime master
>     btw there are some more docbooks which should be removed from plasma-desktop:
>     doc/kcontrol/filetypes/index.docbook:7:<!--FIXME code in kde-cli-tools - docbook in plasma-desktop? -->
>     doc/kcontrol/cache/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/cookies/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/proxy/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/webshortcuts/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/smb/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/netpref/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
>     doc/kcontrol/useragent/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->

These kcm docbooks are now imported with history from kde-runtime master into the new splitted konqueror repo
with https://cgit.kde.org/konqueror.git/commit/?id=9bdf056cd7f0479cbf8400bc7e946d0a8f33ee6e
and will be released in Applications 16.12.
Therefore these kcm docbooks should be deleted from plasma-desktop immediately


- Burkhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128907/#review99166
-----------------------------------------------------------


On Sept. 14, 2016, 2:02 nachm., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128907/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 2:02 nachm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Code for these kcms is in kde-baseapps, therefore the docbooks should be deleted here.
> The docbooks are untouched in plasma-desktop, so it is better to move them with history from kde-runtime master to kde-baseapps see kde-baseapps
> 
> 
> Diffs
> -----
> 
>   doc/kcontrol/bookmarks/CMakeLists.txt 5fba3a1 
>   doc/kcontrol/bookmarks/index.docbook 173222c 
>   doc/kcontrol/filemanager/CMakeLists.txt dfd6879 
>   doc/kcontrol/filemanager/index.docbook 2ac80b6 
>   doc/kcontrol/history/CMakeLists.txt 6b269dc 
>   doc/kcontrol/history/index.docbook 27f805c 
>   doc/kcontrol/kcmcss/CMakeLists.txt 6f1f7e6 
>   doc/kcontrol/kcmcss/index.docbook c63e83c 
>   doc/kcontrol/khtml-adblock/CMakeLists.txt 651f86d 
>   doc/kcontrol/khtml-adblock/index.docbook 1868626 
>   doc/kcontrol/khtml-behavior/CMakeLists.txt 6f26166 
>   doc/kcontrol/khtml-behavior/index.docbook ca39472 
>   doc/kcontrol/khtml-general/CMakeLists.txt ef6dce6 
>   doc/kcontrol/khtml-general/index.docbook 1b9c80e 
>   doc/kcontrol/khtml-java-js/CMakeLists.txt fabc610 
>   doc/kcontrol/khtml-java-js/index.docbook d707fcb 
>   doc/kcontrol/khtml-plugins/CMakeLists.txt b041b5e 
>   doc/kcontrol/khtml-plugins/index.docbook faa4004 
>   doc/kcontrol/performance/CMakeLists.txt 803a3ce 
>   doc/kcontrol/performance/index.docbook 5ac5055 
> 
> Diff: https://git.reviewboard.kde.org/r/128907/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161108/0c71cc50/attachment-0001.html>