<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128907/">https://git.reviewboard.kde.org/r/128907/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2016, 2:55 nachm. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">will you do the move from kde-runtime -> kdebase-apps?</p></pre>
</blockquote>
<p>On September 14th, 2016, 2:57 nachm. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First we may want to split kde-baseapps (see the email on kde-core-devel), but apart from that, yes.</p></pre>
</blockquote>
<p>On September 14th, 2016, 3:44 nachm. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ALeix:
> will you do the move from kde-runtime -> kdebase-apps?
I'll do that when kde-baseapps are splitted
Luigi:
> First we may want to split kde-baseapps (see the email on kde-core-devel), but apart from that, yes.
we should remove the docbooks immediately, it is completely wrong to ship them with Plasma and the konqueror kcm docbooks will be moved from kde-runtime master
btw there are some more docbooks which should be removed from plasma-desktop:
doc/kcontrol/filetypes/index.docbook:7:<!--FIXME code in kde-cli-tools - docbook in plasma-desktop? -->
doc/kcontrol/cache/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/cookies/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/proxy/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/webshortcuts/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/smb/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/netpref/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? -->
doc/kcontrol/useragent/index.docbook:7:<!--FIXME code in frameworks/kio - docbook in plasma-desktop? --></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These kcm docbooks are now imported with history from kde-runtime master into the new splitted konqueror repo
with https://cgit.kde.org/konqueror.git/commit/?id=9bdf056cd7f0479cbf8400bc7e946d0a8f33ee6e
and will be released in Applications 16.12.
Therefore these kcm docbooks should be deleted from plasma-desktop immediately</p></pre>
<br />
<p>- Burkhard</p>
<br />
<p>On September 14th, 2016, 2:02 nachm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation and Plasma.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2016, 2:02 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code for these kcms is in kde-baseapps, therefore the docbooks should be deleted here.
The docbooks are untouched in plasma-desktop, so it is better to move them with history from kde-runtime master to kde-baseapps see kde-baseapps</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kcontrol/bookmarks/CMakeLists.txt <span style="color: grey">(5fba3a1)</span></li>
<li>doc/kcontrol/bookmarks/index.docbook <span style="color: grey">(173222c)</span></li>
<li>doc/kcontrol/filemanager/CMakeLists.txt <span style="color: grey">(dfd6879)</span></li>
<li>doc/kcontrol/filemanager/index.docbook <span style="color: grey">(2ac80b6)</span></li>
<li>doc/kcontrol/history/CMakeLists.txt <span style="color: grey">(6b269dc)</span></li>
<li>doc/kcontrol/history/index.docbook <span style="color: grey">(27f805c)</span></li>
<li>doc/kcontrol/kcmcss/CMakeLists.txt <span style="color: grey">(6f1f7e6)</span></li>
<li>doc/kcontrol/kcmcss/index.docbook <span style="color: grey">(c63e83c)</span></li>
<li>doc/kcontrol/khtml-adblock/CMakeLists.txt <span style="color: grey">(651f86d)</span></li>
<li>doc/kcontrol/khtml-adblock/index.docbook <span style="color: grey">(1868626)</span></li>
<li>doc/kcontrol/khtml-behavior/CMakeLists.txt <span style="color: grey">(6f26166)</span></li>
<li>doc/kcontrol/khtml-behavior/index.docbook <span style="color: grey">(ca39472)</span></li>
<li>doc/kcontrol/khtml-general/CMakeLists.txt <span style="color: grey">(ef6dce6)</span></li>
<li>doc/kcontrol/khtml-general/index.docbook <span style="color: grey">(1b9c80e)</span></li>
<li>doc/kcontrol/khtml-java-js/CMakeLists.txt <span style="color: grey">(fabc610)</span></li>
<li>doc/kcontrol/khtml-java-js/index.docbook <span style="color: grey">(d707fcb)</span></li>
<li>doc/kcontrol/khtml-plugins/CMakeLists.txt <span style="color: grey">(b041b5e)</span></li>
<li>doc/kcontrol/khtml-plugins/index.docbook <span style="color: grey">(faa4004)</span></li>
<li>doc/kcontrol/performance/CMakeLists.txt <span style="color: grey">(803a3ce)</span></li>
<li>doc/kcontrol/performance/index.docbook <span style="color: grey">(5ac5055)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>