Review Request 129329: Fix SVG icon ID prefix

[Marco Martin]

> On Nov. 7, 2016, 4:28 p.m., Marco Martin wrote:
> > Thanks for taking care of it!
> 
> Aleix Pol Gonzalez wrote:
>     @Yunhe, do you have pushing rights or should we push it?
> 
> Yunhe Guo wrote:
>     No, I do not. Maybe you can push it.

since it's a binary change,i can't take it from reviewboard, i would need a tarball with the svgs in it


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129329/#review100687
-----------------------------------------------------------


On Nov. 4, 2016, 3:52 p.m., Yunhe Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129329/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 3:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> As https://bugs.kde.org/show_bug.cgi?id=369622#c5 mentioned, if icon has both 22px and 32px sizes, the 22px one should have prefix of 22-22- in object ID while the 32px one shouldn't. So I checked all existing icons and try to correct wrong IDs.
> 
> I also corrected some object without ID or with wrong ID.
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/breeze/icons/akonadi.svgz 66ee6bd2058fd48e6038bc5114a864b36fb02c33 
>   src/desktoptheme/breeze/icons/akregator.svgz 86a785fc4a08d45e65314657b08a466bcb5698d9 
>   src/desktoptheme/breeze/icons/amarok.svgz 6e36312d5c27f79ef37f9fe8f978c60286a9ddd3 
>   src/desktoptheme/breeze/icons/apport.svgz c8e0e5dee0de3e38026774c0b57cc1f0a2811a4c 
>   src/desktoptheme/breeze/icons/cantata.svgz d62821c832c4873665b08d44cc3a1fb09b915573 
>   src/desktoptheme/breeze/icons/configure.svgz 5ef70002d4c16bd7a0c357911395ee01ec305582 
>   src/desktoptheme/breeze/icons/document.svgz b8ac17c2bf069e0875d47c4e38bf319e9867deaa 
>   src/desktoptheme/breeze/icons/drive.svgz 33af2db07a41b7559eead2b1425c20bf4fb75a52 
>   src/desktoptheme/breeze/icons/edit.svgz e37367d0bd4e94c49ac02be2947d63c8f601506b 
>   src/desktoptheme/breeze/icons/kalarm.svgz 5c3e30db12e3ac68fcd42e18d7ae3e008a09dfd9 
>   src/desktoptheme/breeze/icons/konv_message.svgz 9b790ac21db2abae2c22503c87155de9d1e7103b 
>   src/desktoptheme/breeze/icons/media.svgz 4c1a2e9548042e0daf588da7a70e206f674d8e65 
>   src/desktoptheme/breeze/icons/nepomuk.svgz 3d607207306dadf122bb5eabd0b0ab550ea218fe 
>   src/desktoptheme/breeze/icons/phone.svgz e3c35c8e8b61ddb2100af737bbb27cba7dca6179 
>   src/desktoptheme/breeze/icons/touchpad.svgz d08f2ceaa0b5394e217965e0b00a697dceab1d98 
> 
> Diff: https://git.reviewboard.kde.org/r/129329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yunhe Guo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161108/ebbc9ec8/attachment.html>