<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129329/">https://git.reviewboard.kde.org/r/129329/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 7th, 2016, 4:28 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for taking care of it!</p></pre>
</blockquote>
<p>On November 8th, 2016, 1:21 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Yunhe, do you have pushing rights or should we push it?</p></pre>
</blockquote>
<p>On November 8th, 2016, 5:59 a.m. UTC, <b>Yunhe Guo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, I do not. Maybe you can push it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">since it's a binary change,i can't take it from reviewboard, i would need a tarball with the svgs in it</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On November 4th, 2016, 3:52 p.m. UTC, Yunhe Guo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yunhe Guo.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2016, 3:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As https://bugs.kde.org/show_bug.cgi?id=369622#c5 mentioned, if icon has both 22px and 32px sizes, the 22px one should have prefix of 22-22- in object ID while the 32px one shouldn't. So I checked all existing icons and try to correct wrong IDs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also corrected some object without ID or with wrong ID.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/breeze/icons/akonadi.svgz <span style="color: grey">(66ee6bd2058fd48e6038bc5114a864b36fb02c33)</span></li>
<li>src/desktoptheme/breeze/icons/akregator.svgz <span style="color: grey">(86a785fc4a08d45e65314657b08a466bcb5698d9)</span></li>
<li>src/desktoptheme/breeze/icons/amarok.svgz <span style="color: grey">(6e36312d5c27f79ef37f9fe8f978c60286a9ddd3)</span></li>
<li>src/desktoptheme/breeze/icons/apport.svgz <span style="color: grey">(c8e0e5dee0de3e38026774c0b57cc1f0a2811a4c)</span></li>
<li>src/desktoptheme/breeze/icons/cantata.svgz <span style="color: grey">(d62821c832c4873665b08d44cc3a1fb09b915573)</span></li>
<li>src/desktoptheme/breeze/icons/configure.svgz <span style="color: grey">(5ef70002d4c16bd7a0c357911395ee01ec305582)</span></li>
<li>src/desktoptheme/breeze/icons/document.svgz <span style="color: grey">(b8ac17c2bf069e0875d47c4e38bf319e9867deaa)</span></li>
<li>src/desktoptheme/breeze/icons/drive.svgz <span style="color: grey">(33af2db07a41b7559eead2b1425c20bf4fb75a52)</span></li>
<li>src/desktoptheme/breeze/icons/edit.svgz <span style="color: grey">(e37367d0bd4e94c49ac02be2947d63c8f601506b)</span></li>
<li>src/desktoptheme/breeze/icons/kalarm.svgz <span style="color: grey">(5c3e30db12e3ac68fcd42e18d7ae3e008a09dfd9)</span></li>
<li>src/desktoptheme/breeze/icons/konv_message.svgz <span style="color: grey">(9b790ac21db2abae2c22503c87155de9d1e7103b)</span></li>
<li>src/desktoptheme/breeze/icons/media.svgz <span style="color: grey">(4c1a2e9548042e0daf588da7a70e206f674d8e65)</span></li>
<li>src/desktoptheme/breeze/icons/nepomuk.svgz <span style="color: grey">(3d607207306dadf122bb5eabd0b0ab550ea218fe)</span></li>
<li>src/desktoptheme/breeze/icons/phone.svgz <span style="color: grey">(e3c35c8e8b61ddb2100af737bbb27cba7dca6179)</span></li>
<li>src/desktoptheme/breeze/icons/touchpad.svgz <span style="color: grey">(d08f2ceaa0b5394e217965e0b00a697dceab1d98)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129329/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>