Review Request 129321: Don't redeclare signal and then not use it anyway

David Edmundson david at davidedmundson.co.uk
Mon Nov 7 12:45:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129321/
-----------------------------------------------------------

(Updated Nov. 7, 2016, 12:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit e615d15a4ec67e300124e78a92a0aa9833bc8075 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Fixes runtime warning


Diffs
-----

  src/declarativeimports/core/tooltip.h d38c49ba5b8f20a5ff2a16a87ac935ca20b9a69d 

Diff: https://git.reviewboard.kde.org/r/129321/diff/


Testing
-------

grepped Tooltip.* for usage, and there was none

and any external usage will now just use QQuickItem::visibleChanged() anyway


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/0566f7ad/attachment.html>


More information about the Plasma-devel mailing list