Review Request 129321: Don't redeclare signal and then not use it anyway

Marco Martin notmart at gmail.com
Thu Nov 3 14:00:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129321/#review100538
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Nov. 3, 2016, 1:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129321/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fixes runtime warning
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.h d38c49ba5b8f20a5ff2a16a87ac935ca20b9a69d 
> 
> Diff: https://git.reviewboard.kde.org/r/129321/diff/
> 
> 
> Testing
> -------
> 
> grepped Tooltip.* for usage, and there was none
> 
> and any external usage will now just use QQuickItem::visibleChanged() anyway
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161103/3f7eaa92/attachment.html>


More information about the Plasma-devel mailing list