[Differential] [Updated] D3200: Add a widget gallery page to the Dashboard.

[hein (Eike Hein)]

hein marked 4 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in DashboardRepresentation.qml:102
> Would it help if you pass the containment to the createObject call to avoid some re-evaluation?
> 
>   root.widgetExplorer = widgetExplorerComponent.createObject(root, {
>       containment: containmentInterface.screenContainment(plasmoid)
>   })

Doesn't hurt, will do.

> broulik wrote in containmentinterface.h:53
> Note that you cannot unlock widgets if kiosk restrictions (SystemImmutable) apply in which case this entire feature should be disabled or else you open a neat way for users to screw with a locked-down desktop.

Yep, note the review update that added a SystemImmutable check hiding the tab bar (and thus the entire feature).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3200

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161101/5a2c3198/attachment.html>