[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[xuetianweng (Xuetian Weng)]

xuetianweng added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:449
> > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.
> 
> That's totally fine in this case. It only affects KWin and KWin doesn't have any text input fields.
> 
> > IMHO for wayland there should be a wayland specific im module that talk to input method via wl_text.
> 
> QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think that's exactly what you want.
> 
> > And X11 app should use a different QT_IM_MODULE.
> 
> Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all.

Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the session I wonder if it will be inherit by the whole desktop session.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/ca315d23/attachment.html>