[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.
> 
> IMHO for wayland there should be  a wayland specific im module that talk to input method via wl_text.
> 
> And X11 app should use a different QT_IM_MODULE.
> 
> FYI: https://fcitx-im.org/wiki/Input_method_related_environment_variables

> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.

That's totally fine in this case. It only affects KWin and KWin doesn't have any text input fields.

> IMHO for wayland there should be a wayland specific im module that talk to input method via wl_text.

QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think that's exactly what you want.

> And X11 app should use a different QT_IM_MODULE.

Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/ffb0c19f/attachment-0001.html>