Review Request 128052: Improve agenda view in digital-clock applet

[Andreas Kainz]

> On Mai 30, 2016, 11:55 vorm., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment601>
> >
> >     first column entry is needed (today or all day in the first column)
> 
> Daniel Vrátil wrote:
>     I'm not sure about this. No time already implies it's an unbound event, IMO no need to be more explicit. Also with a string-based indicator (like "Today") it would IMO be harder to distinguish where the "Today" label ends and where the actual event title starts.

now you don't have an input for the first column and this look a bit out of place.


> On Mai 30, 2016, 11:55 vorm., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment602>
> >
> >     third column for specific elements like importend, how many people are invited, ... I don't know if this is possible (available)
> 
> Daniel Vrátil wrote:
>     I think this is out-of-scope for this applet - if you want this kind of information, just open KOrganizer ;-)

true


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/#review96033
-----------------------------------------------------------


On Mai 29, 2016, 11:11 nachm., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128052/
> -----------------------------------------------------------
> 
> (Updated Mai 29, 2016, 11:11 nachm.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Klapetek, and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128052/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/3490dff1/attachment.html>