Review Request 128052: Improve agenda view in digital-clock applet

[Daniel Vrátil]

> On May 30, 2016, 1:55 p.m., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment597>
> >
> >     third column for specific elements like importend, how many people are invited, ... I don't know if this is possible (available)

I think this is out-of-scope for this applet - if you want this kind of information, just open KOrganizer ;-)


> On May 30, 2016, 1:55 p.m., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment598>
> >
> >     first column entry is needed (today or all day in the first column)

I'm not sure about this. No time already implies it's an unbound event, IMO no need to be more explicit. Also with a string-based indicator (like "Today") it would IMO be harder to distinguish where the "Today" label ends and where the actual event title starts.


> On May 30, 2016, 1:55 p.m., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment599>
> >
> >     second column left top align with header in white and description in another color (gray, same than end time)

Yeah, the alignment needs a bit of work. I guess the first column could have a fixed width based on the longest possible time string in current locale.

I already wanted to make it gray-ish, but couldn't figure out how to get the right color (possibly TextColor from the Disabled palette?) from the Plasma Theme in QML. Plasma wizards, help! :)


> On May 30, 2016, 1:55 p.m., Andreas Kainz wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment600>
> >
> >     table with right align start time more visible than end time (gray color)

Maybe I could make the start time bold, like the event title. I'll play around with that a bit.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/#review96033
-----------------------------------------------------------


On May 30, 2016, 1:11 a.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128052/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 1:11 a.m.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Klapetek, and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128052/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/52f61f0f/attachment-0001.html>