[Differential] [Requested Changes To] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

[graesslin (Martin Gräßlin)]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panelview.cpp:593
>  #if HAVE_X11
> -    xcb_connection_t *c = QX11Info::connection();
> -    if (!c) {
> +    if (!QX11Info::isPlatformX11()) {
>          return;

I suggest to move the complete X11 block into the if. So that we can in future add an
else if (isWayland())

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/a5f9ea25/attachment-0001.html>