[Differential] [Request, 5 lines] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Mon May 30 14:36:27 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QX11Info::connection() looks up the connection in the QPA. The Wayland QPA happens to have a property with the same name, so it happily reinterpret_casts a wl_connection_t* to xcb_connection_t* and disaster ensues.

TEST PLAN
  Auto hiding panels still works on X11, haven't tested Wayland.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1718

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, graesslin
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160530/6d0cd864/attachment.html>


More information about the Plasma-devel mailing list