Review Request 128052: Improve agenda view in digital-clock applet

[David Edmundson]

> On May 29, 2016, 10:20 p.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 250
> > <https://git.reviewboard.kde.org/r/128052/diff/1/?file=467275#file467275line250>
> >
> >     font.bold: true
> 
> Daniel Vrátil wrote:
>     Doesn't work for some reason :(
> 
> Kai Uwe Broulik wrote:
>     Plasma label sets font weight from theme which overrides that apparently, ie. font.bold true just sets weight to Font.Bold so it doesn't work because of that. Pity :)

The reason is that PlasmaComponents.Label has

"font.weight: theme.defaultFont.weight"


Inside QQuickFontValueType bold and weight are stored as two different variables so you can't rely on the fact that this is being evalutated after like you would for overriding most properties.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/#review96008
-----------------------------------------------------------


On May 29, 2016, 10:14 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128052/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 10:14 p.m.)
> 
> 
> Review request for Plasma, Martin Klapetek and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128052/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160529/b60bc17b/attachment.html>